Greg Padgett has posted comments on this change. Change subject: Add metadata storage support for raw block device ......................................................................
Patch Set 4: Code-Review+1 (3 comments) http://gerrit.ovirt.org/#/c/25798/4//COMMIT_MSG Commit Message: Line 21: 8B index of next meta block or 0 if this is the last one Line 22: 64 bytes with service name (first byte equals the used length) Line 23: 8B + 8B pointers to data section (start block, length) Line 24: ... more data sections if needed Line 25: 16B of 0 acting as a sentinel 4B reserved before sentinel? (92+16n is defined, might as well make it an even multiple and fill the block :)) Line 26: 4B CRC32 checksum Line 27: Line 28: If there is need to use lots of data sections for a single service, Line 29: is is possible tp use the service name multiple times and the data http://gerrit.ovirt.org/#/c/25798/4/ovirt_hosted_engine_ha/lib/storage_backends.py File ovirt_hosted_engine_ha/lib/storage_backends.py: Line 277: logger.debug("Table for %s\n%s", name, table) Line 278: stdout, stderr = dm.communicate(table) Line 279: dm.wait() Line 280: logger.debug("dmcreate %s stdout: %s", name, stdout) Line 281: logger.debug("dmcreate %s stderr: %s", name, stderr) If the return code isn't 0, this diagnostic logging would be useful at a higher log level Line 282: logger.info("dmcreate %s return code: %d", name, dm.returncode) Line 283: Line 284: def dmremove(self, name, popen=subprocess.Popen): Line 285: """ Line 292: stdout, stderr = dm.communicate() Line 293: Line 294: dm.wait() Line 295: logger.debug("dmremove %s stdout: %s", name, stdout) Line 296: logger.debug("dmremove %s stderr: %s", name, stderr) Same as above Line 297: logger.info("dmremove %s return code: %d", name, dm.returncode) Line 298: Line 299: def filename(self, service): Line 300: if service not in self._services: -- To view, visit http://gerrit.ovirt.org/25798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6ab21fb2075fc59b444b5754ade8a1569b83b18 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
