Lior Vernia has uploaded a new change for review.

Change subject: webadmin: Allow empty gateway
......................................................................

webadmin: Allow empty gateway

I think the previous code was attempting to do the same thing, but did
so in an inconsistent manner.

Change-Id: I3aa805267e35c7f4f84b6c155db8bb002f5dc62a
Bug-Url: https://bugzilla.redhat.com/1075981
Signed-off-by: Lior Vernia <lver...@redhat.com>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/16/25816/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
index 0591c9d..35b4c15 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java
@@ -392,9 +392,7 @@
         {
             getAddress().validateEntity(new IValidation[] { new 
NotEmptyValidation(), new IpAddressValidation() });
             getSubnet().validateEntity(new IValidation[] { new 
NotEmptyValidation(), new SubnetMaskValidation() });
-            if (getGateway().getEntity() != null) {
-                getGateway().validateEntity(new IValidation[] { new 
IpAddressValidation() });
-            }
+            getGateway().validateEntity(new IValidation[] { new 
IpAddressValidation(true) });
         }
 
         getQosModel().validate();


-- 
To view, visit http://gerrit.ovirt.org/25816
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3aa805267e35c7f4f84b6c155db8bb002f5dc62a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to