Sandro Bonazzola has posted comments on this change. Change subject: Providing details about the required free space ......................................................................
Patch Set 2: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/25791/2/src/plugins/ovirt-hosted-engine-setup/storage/storage.py File src/plugins/ovirt-hosted-engine-setup/storage/storage.py: Line 800: raise e Line 801: except ohosteddomains.InsufficientSpaceError as e: Line 802: self.logger.debug('exception', exc_info=True) Line 803: self.logger.debug(e) Line 804: m = (ohostedcons.Const.MINIMUM_SPACE_STORAGEDOMAIN_MB / 1024.0) no need for parenthesis here. You can also do this in one step keeping parenthesis: >>> min_requirement = '%0.2f' % ( >>> ohostedcons.Const.MINIMUM_SPACE_STORAGEDOMAIN_MB / 1024.0 >>> ) Line 805: mf = "%0.2f" % m Line 806: if interactive: Line 807: self.logger.error( Line 808: _( Line 808: _( Line 809: 'Storage domain for self hosted engine ' Line 810: 'is too small: ' Line 811: 'you should have at least ' + mf + ' GB free' Line 812: ) please use 'you should have at least {min_requirement} GB free'.format( min_requirement=mf, ) it's easier to translate. Line 813: ) Line 814: else: Line 815: raise RuntimeError( Line 816: _( Line 815: raise RuntimeError( Line 816: _( Line 817: 'Storage domain for self hosted engine ' Line 818: 'is too small: ' Line 819: 'you should have at least ' + mf + ' GB free' same here Line 820: ) Line 821: ) Line 822: if self.environment[ Line 823: ohostedcons.StorageEnv.DOMAIN_TYPE -- To view, visit http://gerrit.ovirt.org/25791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab06eeb467b6003a27bbe3566f0d64336f9d0728 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
