[Engine-patches] Change in ovirt-engine[master]: core: Use List.addAll() instead of iteration

[masayag]

Moti Asayag has uploaded a new change for review.

Change subject: core: Use List.addAll() instead of iteration
......................................................................

core: Use List.addAll() instead of iteration

Change-Id: I0e1e562734e1ebc341a3ad96cc104aff649087aa
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStatsVDSCommand.java
1 file changed, 3 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/25793/1

diff --git 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStatsVDSCommand.java
 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStatsVDSCommand.java
index cc492b6..e296e3b 100644
--- 
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStatsVDSCommand.java
+++ 
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetStatsVDSCommand.java
@@ -4,7 +4,6 @@
 
 import 
org.ovirt.engine.core.common.businessentities.network.VdsNetworkInterface;
 import 
org.ovirt.engine.core.common.vdscommands.VdsIdAndVdsVDSCommandParametersBase;
-import org.ovirt.engine.core.dal.dbbroker.DbFacade;
 import org.ovirt.engine.core.utils.log.Logged;
 import org.ovirt.engine.core.utils.log.Logged.LogLevel;
 
@@ -24,12 +23,10 @@
         infoReturn = getBroker().getVdsStats();
         proceedProxyReturnValue();
         if (getVds().getInterfaces().isEmpty()) {
-            List<VdsNetworkInterface> interfaces = 
DbFacade.getInstance().getInterfaceDao().getAllInterfacesForVds(
-                    getVds().getId());
-            for (VdsNetworkInterface iface : interfaces) {
-                getVds().getInterfaces().add(iface);
-            }
+            List<VdsNetworkInterface> nics = 
getDbFacade().getInterfaceDao().getAllInterfacesForVds(getVds().getId());
+            getVds().getInterfaces().addAll(nics);
         }
+
         VdsBrokerObjectsBuilder.updateVDSStatisticsData(getVds(), 
infoReturn.mInfo);
         VdsBrokerObjectsBuilder.checkTimeDrift(getVds(), infoReturn.mInfo);
     }


-- 
To view, visit http://gerrit.ovirt.org/25793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e1e562734e1ebc341a3ad96cc104aff649087aa
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches