Gilad Chaplik has posted comments on this change. Change subject: engine, webadmin: Re-work engine ovirt-node host-deploy sequence ......................................................................
Patch Set 6: (4 comments) http://gerrit.ovirt.org/#/c/25685/6//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-03-13 15:39:34 -0400 Line 6: Line 7: engine, webadmin: Re-work engine ovirt-node host-deploy sequence Line 8: Line 9: The current host delpy sequence does not typo Line 10: let the oVirt node to be redeployed, it Line 11: can only be upgrdaed. Line 12: Line 13: Split the back end InstallVdsCommand into two Line 7: engine, webadmin: Re-work engine ovirt-node host-deploy sequence Line 8: Line 9: The current host delpy sequence does not Line 10: let the oVirt node to be redeployed, it Line 11: can only be upgrdaed. typo Line 12: Line 13: Split the back end InstallVdsCommand into two Line 14: commands, InstallVds and UpdateVdsCommand. Line 15: InstallVds is used to redeploy host and http://gerrit.ovirt.org/#/c/25685/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsInternalCommand.java: Line 28: } Line 29: Line 30: @Override Line 31: protected boolean canDoAction() { Line 32: if (getVdsId() == null || getVdsId().equals(Guid.Empty)) { Guid.isNullOrEmpty(.. Line 33: return failCanDoAction(VdcBllMessages.VDS_INVALID_SERVER_ID); Line 34: } Line 35: if (getVds() == null) { Line 36: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST); http://gerrit.ovirt.org/#/c/25685/6/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java: Line 57: public static final String PmPortKey = "port"; //$NON-NLS-1$ Line 58: public static final String PmSlotKey = "slot"; //$NON-NLS-1$ Line 59: public static final String BeginTestStage = "BeginTest"; //$NON-NLS-1$ Line 60: public static final String EndTestStage = "EndTest"; //$NON-NLS-1$ Line 61: public static final String AdminUserName = "admin"; //$NON-NLS-1$ can admin@internal be configured? Line 62: public static final String RootUserName = "root"; //$NON-NLS-1$ Line 63: Line 64: private UICommand privateTestCommand; Line 65: UIConstants constants = ConstantsManager.getInstance().getConstants(); -- To view, visit http://gerrit.ovirt.org/25685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a897581e2b75f7cdc57db40418504a79b9d2787 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
