Jiří Moskovčák has posted comments on this change. Change subject: Add nice interactive html representation of the agent's state machine ......................................................................
Patch Set 1: (2 comments) please rebase the against the clean master + added few minor comments inline. http://gerrit.ovirt.org/#/c/25654/1/doc/agent-fsm.html File doc/agent-fsm.html: Line 41: <body> Line 42: <div id='graph'> Line 43: </div> Line 44: <script language='javascript'> Line 45: var data = {"packageNames": ["EngineMigratingAway", "GlobalMaintenance", "EngineStop", "EngineStart", "ReinitializeFSM", "LocalMaintenanceMigrateVm", "UnknownLocalVmState", "EngineUp", "StartState", "EngineDown", "LocalMaintenance", "EngineUpBadHealth", "EngineForceStop", "EngineUnexpectedlyDown"], "matrix": [[1, 1, 0, 0, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0], [0, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0], [0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, 0], [0, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1, 0, 0, 0], [0, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1, 0, 0, 0], [1, 1, 1, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0], [0, 1, 0, 0, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0], [1, 1, 1, 0, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1], [0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0], [0, 1, 0, 1, 0, 0, 1, 1, 0, 1, 1, 0, 0, 0], [0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0], [1, 1, 1, 0, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1], [0, 1, 0, 0, 1, 0, 1, 0, 0, 1, 1, 0, 0, 0], [0, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1, 0, 0, 1]]}; I would prefer if you format this as a matrix, it would be more readable Line 46: var chart = d3.chart.dependencyWheel() Line 47: .width(700) // also used for height, since the wheel is in a a square Line 48: .margin(150) // used to display package names Line 49: .padding(.02); // separating groups in the wheel Line 52: .call(chart); Line 53: </script> Line 54: </body> Line 55: </html> Line 56: trailing space!! :) -- To view, visit http://gerrit.ovirt.org/25654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82c72d044818c8412a2517a4431aecf8412add7d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
