Lior Vernia has posted comments on this change. Change subject: webadmin: Adding Quota column to the Disk tab ......................................................................
Patch Set 1: (1 comment) I would use StringHelper, if it were up to me. http://gerrit.ovirt.org/#/c/25068/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java: Line 56: Line 57: String value = null; Line 58: if (object.getDiskStorageType() == DiskStorageType.IMAGE) { Line 59: DiskImage diskImage = (DiskImage) object; Line 60: value = diskImage.getQuotaName(); > StringHelper is deprecated, and we cannot use apache's StringUtils because I would use StringHelper, which is known to work, than duplicate the logic everywhere it's needed (and this logic is quite common). Looking at the patch that deprecated StringHelper [Ibe8512c55ad0a7f1a9622533625db5d75c5f982b], as well as a following one by Mike Kolesnik, I would say the reason it was marked as deprecated was to stop its usage in the backend. In the frontend I don't know of any better alternative. Line 61: } Line 62: return value; Line 63: } Line 64: }; -- To view, visit http://gerrit.ovirt.org/25068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
