Liron Ar has uploaded a new change for review.
Change subject: core: increment vm/templates db generation on pool ver upgrade
......................................................................
core: increment vm/templates db generation on pool ver upgrade
When upgrading the storage pool comptability version to one that
supports the OvfStoreOnAnyDomain feature, the vms/templates db
generation should be incremented so that ovf configuration will be
generated and saved for those vms/templates.
Without it being done on the next run of the ovf update process
for a domain we might store ovf with missing ovf configurations
(as they were never generated and saved).
Change-Id: Ief1a984a7d275d558bbe74bbca6bd49326267e43
Signed-off-by: Liron Aravot <lara...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/79/25779/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
index f01de63..c7a2166 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
@@ -8,6 +8,7 @@
import org.ovirt.engine.core.bll.RenamedEntityInfoProvider;
import org.ovirt.engine.core.bll.utils.VersionSupport;
import org.ovirt.engine.core.common.AuditLogType;
+import org.ovirt.engine.core.common.FeatureSupported;
import org.ovirt.engine.core.common.VdcObjectType;
import org.ovirt.engine.core.common.action.StoragePoolManagementParameter;
import org.ovirt.engine.core.common.businessentities.StorageDomain;
@@ -109,6 +110,9 @@
public Object runInTransaction() {
getStoragePoolDAO().updatePartial(storagePool);
updateMemberDomainsFormat(targetFormat);
+ if (FeatureSupported.ovfStoreOnAnyDomain(spVersion)) {
+
getVmStaticDAO().incrementDbGenerationForAllInStoragePool(spId);
+ }
return null;
}
});
--
To view, visit http://gerrit.ovirt.org/25779
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief1a984a7d275d558bbe74bbca6bd49326267e43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
