Shirly Radco has posted comments on this change.

Change subject: reports: br9 report - added comments to queries
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.ovirt.org/#/c/25147/4/packaging/ovirt-reports/resources/Reports/Inventory/VM_Inventory_files/VM_Inventory_jrxml.data
File 
packaging/ovirt-reports/resources/Reports/Inventory/VM_Inventory_files/VM_Inventory_jrxml.data:

Line 133:                     AND enum_translator_localized.enum_key =
Line 134:                     enum_translator_default.enum_key
Line 135:                 )
Line 136:             WHERE language_code = 'en_US'
Line 137:             )
> needs to be one back
Done
Line 138:             AS b
Line 139:                 ON (
Line 140:                     v3_4_configuration_history_vms.operating_system =
Line 141:                     b.enum_key AND b.enum_type = 'OS_TYPE'


Line 139:                 ON (
Line 140:                     v3_4_configuration_history_vms.operating_system =
Line 141:                     b.enum_key AND b.enum_type = 'OS_TYPE'
Line 142:                 )
Line 143:             LEFT OUTER JOIN v3_4_configuration_history_clusters
> move one back
Done
Line 144:                 ON (
Line 145:                     v3_4_configuration_history_vms.cluster_id =
Line 146:                     v3_4_configuration_history_clusters.cluster_id
Line 147:                     AND 
v3_4_configuration_history_clusters.history_id IN (


-- 
To view, visit http://gerrit.ovirt.org/25147
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7215dbbd2c5e457229055daad4283fe0606b9abe
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Shirly Radco <sra...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to