Yaniv Dary has posted comments on this change. Change subject: reports: edited ic query-only_hosts_host_type ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/25414/3/packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/P_Host_Type.xml File packaging/ovirt-reports/resources/reports_resources/JDBC/Input_Controls/Regular_Input_Controls/Only_Hosts/P_Host_Type.xml: Line 35 Line 36 Line 37 Line 38 Line 39 Please change to UNION ALL, it's less heavy on the db Line 71: ELSE CAST ( $P{P_Cluster_ID} AS uuid ) Line 72: END Line 73: -- This will determine if deleted entities will be included in the report, Line 74: -- according to the user selection for "is_deleted" parameter Line 75: $P!{active_hosts_select} is_deleted -> active_hosts_select Line 76: Line 77: UNION Line 78: Line 79: -- Here we add the "All" option to the select list, -- To view, visit http://gerrit.ovirt.org/25414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic42e9313c3ab8ebd66e8f6023343f343e345497d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
