Martin Sivák has posted comments on this change. Change subject: broker: accept empty success messages ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/25621/2/ovirt_hosted_engine_ha/lib/brokerlink.py File ovirt_hosted_engine_ha/lib/brokerlink.py: Line 187: response = self._communicate(request) Line 188: parts = response.split(" ", 1) Line 189: if len(parts) >= 1 and parts[0] == "success": Line 190: self._log.debug("Successful response from socket") Line 191: return parts[1] If there is only one part (success) then return parts[1] will crash.. Line 192: else: Line 193: self._log.debug("Failed response from socket") Line 194: if len(parts) > 1: Line 195: msg = parts[1] -- To view, visit http://gerrit.ovirt.org/25621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5024c05f592d1bae46ebb759f30c600faf964596 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
