Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Change builtin authenticators and directories 
initialization
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25741/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java:

Line 108: 
Line 109:         new DwhHeartBeat().init();
Line 110:     }
Line 111: 
Line 112:     private List<Properties> createInternalConfigurations() {
> 1. create packaging/extensions.d
ok, continuing my previous comment...

if we put values of vdc_options into properties, we should leave internal here, 
just read the admin password into property for provider to read.
Line 113:         List<Properties> results = new ArrayList<>();
Line 114:         Properties authConfig = new Properties();
Line 115:         authConfig.put(ExtensionManager.CLASS, 
"org.ovirt.extensions.builtin.ldapkerberos.LdapKerberosAuthenticator");
Line 116:         authConfig.put(ExtensionManager.PROVIDES, 
"org.ovirt.engine.core.authentication");


-- 
To view, visit http://gerrit.ovirt.org/25741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8513cb992c5becef7e83c04a8da8bc7f1622348
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to