Sandro Bonazzola has posted comments on this change.

Change subject: bin: add the host to a specific cluster
......................................................................


Patch Set 11: Verified-1

(1 comment)

Just a minimal failure, but need to be fixed.

http://gerrit.ovirt.org/#/c/25456/11/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py:

Line 426:                     'the host (@VALUES@) [@DEFAULT@]: '
Line 427:                 ),
Line 428:                 prompt=True,
Line 429:                 default=cluster_name,
Line 430:                 validValues=','.join(cluster_l),
The above outputs:

 Enter the name of the cluster to which you want to add the host (D, e, f, a, 
u, l, t) [Default]:

My bad, should be:
validValues=cluster_l,
Line 431:             )
Line 432:             engine_api.hosts.add(
Line 433:                 self._ovirtsdk_xml.params.Host(
Line 434:                     name=self.environment[


-- 
To view, visit http://gerrit.ovirt.org/25456
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Meital Bourvine <mbour...@redhat.com>
Gerrit-Reviewer: Meital bourvine <meitalbourv...@gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to