Juan Hernandez has posted comments on this change. Change subject: restapi: add support for import image as template ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25715/1/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 1345: body: Line 1346: parameterType: Action Line 1347: signatures: Line 1348: - mandatoryArguments: {storagedomain.id|name: 'xs:string'} Line 1349: optionalArguments: {action.async: 'xs:boolean', action.grace_period.expiry: 'xs:long', action.importAsTemplate: 'xs:boolean', action.cluster.id|name: 'xs:string'} The name of the parameter here should be like in the XML schema: import_as_template. This isn't relevant for the API itself, but it is for the SDKs and the CLI. Line 1350: urlparams: {} Line 1351: headers: Line 1352: Content-Type: {value: application/xml|json, required: true} Line 1353: Correlation-Id: {value: 'any string', required: false} http://gerrit.ovirt.org/#/c/25715/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java: Line 218: } Line 219: } Line 220: Line 221: protected VDSGroup lookupClusterByName(String name) { Line 222: return getEntity(VDSGroup.class, VdcQueryType.GetVdsGroupByName, new NameQueryParameters(name), "GetVdsGroupByName"); The last parameter of the "getEntity" method will be presented to the user in case of error. Putting there the name of the query type won't help, as it is an internal detail. Please use the following: "Cluster: name=" + name Line 223: } Line 224: Line 225: protected Guid lookupStorageDomainIdByName(String name) { Line 226: if (!isFiltered()) { -- To view, visit http://gerrit.ovirt.org/25715 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5efa82616c3fa3944800542aafce14d550bd74d9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
