Alon Bar-Lev has posted comments on this change. Change subject: aaa: Introducing built-in extensions module ......................................................................
Patch Set 6: (2 comments) nice!!! http://gerrit.ovirt.org/#/c/25253/6/backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml File backend/manager/modules/builtin-extensions/src/main/modules/org/ovirt/engine/extensions/builtin/main/module.xml: Line 17: <module name="org.ovirt.engine.api.ovirt-engine-extensions-api"/> Line 18: <module name="org.springframework"/> Line 19: <module name="org.apache.commons.logging"/> Line 20: <module name="org.apache.log4j"/> Line 21: <module name="org.ovirt.engine.core.common"/> please sort() Line 22: <module name="sun.jdk"/> Line 23: </dependencies> Line 24: http://gerrit.ovirt.org/#/c/25253/6/backend/manager/modules/builtin-extensions/src/test/org/ovirt/engine/core/extensions/aaa/builtin/kerberosldap/LdapFilterSearchEnginePreProcessorTest.java File backend/manager/modules/builtin-extensions/src/test/org/ovirt/engine/core/extensions/aaa/builtin/kerberosldap/LdapFilterSearchEnginePreProcessorTest.java: Line 1: package org.ovirt.engine.extensions.aaa.builtin.kerberosldap;y typo Line 2: Line 3: import static org.junit.Assert.assertEquals; Line 4: Line 5: import org.junit.Test; -- To view, visit http://gerrit.ovirt.org/25253 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7ea408b46548ffdad1bf56fb8ab54b68722a480 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
