Allon Mureinik has uploaded a new change for review. Change subject: core: TagsDirector private static methods ......................................................................
core: TagsDirector private static methods Make private methods static where possible to enhance performance. Change-Id: I668244c5a09e58355478b4d38a21c40ba6a48925 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/25671/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java index 6e3da01..1fc2b3c 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java @@ -79,7 +79,7 @@ } } - private void replaceTagInChildren(Tags tag, List<Tags> parentChildren) { + private static void replaceTagInChildren(Tags tag, List<Tags> parentChildren) { for (int counter = 0; counter < parentChildren.size(); counter++) { if (parentChildren.get(counter).gettag_id().equals(tag.gettag_id())) { parentChildren.set(counter, tag); @@ -290,7 +290,7 @@ return sb.toString(); } - private void RecursiveGetTagsAndChildrenByRegExp(String tagNameRegExp, StringBuilder sb, Tags tag, TagReturnValueIndicator indicator ) { + private static void RecursiveGetTagsAndChildrenByRegExp(String tagNameRegExp, StringBuilder sb, Tags tag, TagReturnValueIndicator indicator) { if ((tag.getChildren() != null) && (tag.getChildren().size() > 0)) { // The following line replaces '\\' in the expression that may be added by handling a '_' character with empty string. // since we have here both String and RegExp , each backslash char is represented by four backslash chars , so for marching 2 we will need 8 -- To view, visit http://gerrit.ovirt.org/25671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I668244c5a09e58355478b4d38a21c40ba6a48925 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
