Alexander Wels has uploaded a new change for review. Change subject: userportal,webadmin: snapshot subtab action bar ......................................................................
userportal,webadmin: snapshot subtab action bar - When using the splitter to resize the snapshot section of the snapshot sub tab the action bar would not automatically create the dropdown menu when not enough room existed. This patch fixes that problem in both user portal and web admin Change-Id: I8f587170fffba3bc4d27a0144cd02f4ed2a2aa52 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1071387 Signed-off-by: Alexander Wels <aw...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml 4 files changed, 11 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/25667/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java index 1ba5350..236165c 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/AbstractActionPanel.java @@ -50,6 +50,7 @@ import com.google.gwt.user.client.ui.MenuItem; import com.google.gwt.user.client.ui.MenuItemSeparator; import com.google.gwt.user.client.ui.PushButton; +import com.google.gwt.user.client.ui.RequiresResize; import com.google.gwt.user.client.ui.Widget; /** @@ -64,7 +65,7 @@ * Action panel item type. */ public abstract class AbstractActionPanel<T> extends Composite implements ActionPanel<T>, HasElementId, - ProvidesElementId { + ProvidesElementId, RequiresResize { /** * The cascading menu/panel CSS resources. */ @@ -221,6 +222,11 @@ }); } + @Override + public void onResize() { + initializeCascadeMenuPanel(); + } + /** * Initialize the cascade menu panel. */ diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.ui.xml index 103eb80..2c26e74 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/action/DropdownActionButton.ui.xml @@ -26,9 +26,7 @@ .container { float: left; - padding-right: 3px; - margin-right: -3px; - margin-left: 10px; + padding-left: 10px; border: 1px solid transparent; } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java index 49dc18e..a23609e 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java @@ -5,6 +5,7 @@ import com.google.gwt.event.shared.EventBus; import com.google.gwt.uibinder.client.UiBinder; import com.google.gwt.uibinder.client.UiField; +import com.google.gwt.user.client.ui.LayoutPanel; import com.google.gwt.user.client.ui.SimplePanel; import com.google.gwt.user.client.ui.Widget; import org.ovirt.engine.core.common.action.VdcActionType; @@ -30,7 +31,6 @@ import org.ovirt.engine.ui.uicompat.Event; import org.ovirt.engine.ui.uicompat.EventArgs; import org.ovirt.engine.ui.uicompat.IEventListener; - import java.util.HashMap; import java.util.LinkedList; import java.util.List; @@ -42,7 +42,7 @@ } @UiField - SimplePanel snapshotsTableContainer; + LayoutPanel snapshotsTableContainer; @UiField SimplePanel snapshotInfoContainer; diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml index 37690f0..0e37494 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.ui.xml @@ -41,7 +41,7 @@ <g:SplitLayoutPanel addStyleNames="{style.container}"> <g:west size="500"> - <g:SimplePanel ui:field="snapshotsTableContainer"/> + <g:LayoutPanel ui:field="snapshotsTableContainer"/> </g:west> <g:center> <g:SimplePanel ui:field="snapshotInfoContainer"/> -- To view, visit http://gerrit.ovirt.org/25667 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8f587170fffba3bc4d27a0144cd02f4ed2a2aa52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
