Gilad Chaplik has posted comments on this change. Change subject: core, engine, webadmin: Maintenance operations on a VM would ask for an optional reason ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/25633/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/RemoveConfirmationWithCommentPopupPresenterWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/RemoveConfirmationWithCommentPopupPresenterWidget.java: Line 7: Line 8: /** Line 9: * Implements the remove confirmation dialog bound to UiCommon {@link org.ovirt.engine.ui.uicommonweb.models.ConfirmationModel}. Line 10: */ Line 11: public class RemoveConfirmationWithCommentPopupPresenterWidget extends AbstractModelBoundPopupPresenterWidget<ConfirmationWithReasonModel, RemoveConfirmationWithCommentPopupPresenterWidget.ViewDef> { can't you you existing stuff we have? Line 12: Line 13: public interface ViewDef extends AbstractModelBoundPopupPresenterWidget.ViewDef<ConfirmationWithReasonModel> { Line 14: } Line 15: -- To view, visit http://gerrit.ovirt.org/25633 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17645e5bc97a1a4d460956ec45f88524465dfd7b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
