Alon Bar-Lev has posted comments on this change. Change subject: core: integrate make into maven ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/25661/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-03-12 14:39:38 +0200 Line 6: Line 7: core: integrate make into maven Line 8: Line 9: mvn install -Pmake -Pprefix=my-prefix why not -Dprefix? Line 10: Line 11: Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 http://gerrit.ovirt.org/#/c/25661/1/mavenmake/pom.xml File mavenmake/pom.xml: Line 13: <name>ovirt engine maven make</name> Line 14: <description>ovirt engine maven make</description> Line 15: Line 16: <properties> Line 17: <prefix>${env.PREFIX}</prefix> devenv.prefix? Line 18: </properties> Line 19: Line 20: <profiles> Line 21: <profile> Line 35: <artifactId>exec-maven-plugin</artifactId> Line 36: <version>1.2.1</version> Line 37: <executions> Line 38: <execution> Line 39: <phase>install</phase> won't it better to do this on deploy? Line 40: <goals> Line 41: <goal>exec</goal> Line 42: </goals> Line 43: </execution> Line 45: <configuration> Line 46: <executable>make</executable> Line 47: <!-- optional --> Line 48: <workingDirectory>${project.parent.basedir}</workingDirectory> Line 49: <arguments> use -C ${project.parent.basedir} instead of cd. Line 50: <argument>install-dev</argument> Line 51: <argument>PREFIX=${prefix}</argument> Line 52: <argument>DEV_REBUILD=0</argument> Line 53: </arguments> -- To view, visit http://gerrit.ovirt.org/25661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8981f04b26a2d36429f8bfccaada8dfbadfbf9c3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
