Alexander Wels has posted comments on this change. Change subject: webadmin: DC subtab refreshes shows loading indicator ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25593/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java: Line 82: if (value == null) { Line 83: this.comment = ""; Line 84: } else { Line 85: this.comment = value; Line 86: } > this.comment = (value == null) ? "" : value; Checkstyle discourages the use of the ternary operator. I agree with that. I could do the following if there is too much code for you: assert value != null : "Comment should not be null"; comment = value; Line 87: } Line 88: Line 89: @Override Line 90: public Guid getId() { -- To view, visit http://gerrit.ovirt.org/25593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ae44a6ea127b4e3b35647721fd2e927bac130b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
