Eli Mesika has uploaded a new change for review. Change subject: core: enable to decrease DC compatibility... ......................................................................
core: enable to decrease DC compatibility... enable to decrease DC compatibility version if DC has no clusters This patch enables to decrease the DC compatibility version if DC has no clusters. Change-Id: I73284f641b7f80b380b39efbbd7b4566f55119b6 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1057029 Signed-off-by: Eli Mesika <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/37/25637/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java index 192f199..f01de63 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java @@ -182,8 +182,11 @@ } // decreasing of compatibility version is not allowed else if (getStoragePool().getcompatibility_version().compareTo(_oldStoragePool.getcompatibility_version()) < 0) { - returnValue = false; - addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); + // Enable to reduce compatibility version if DC has no clusters + if (getVdsGroupDAO().getAllForStoragePool(getStoragePoolId()).size() > 0) { + returnValue = false; + addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_CANNOT_DECREASE_COMPATIBILITY_VERSION); + } } else { // Check all clusters has at least the same compatibility version. returnValue = checkAllClustersLevel(); -- To view, visit http://gerrit.ovirt.org/25637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I73284f641b7f80b380b39efbbd7b4566f55119b6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
