Eli Mesika has uploaded a new change for review. Change subject: core: set DC compatability version to latest... ......................................................................
core: set DC compatability version to latest... Set DC compatibility version to latest when null Up to now when adding a DC from API without giving explicitly the compatibility version was resulted in a failure on unsupported version. This patch changes this behaviour by setting the latest version as a default if a null was given for compatibility version. Change-Id: I53373e9ce2563d91a96353f068cd19069508399d Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1053062 Signed-off-by: Eli Mesika <emes...@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/34/25634/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java index 436fa51..186f587 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StoragePool.java @@ -141,7 +141,7 @@ public Version getcompatibility_version() { if (version == null) { - version = new Version(compatibilityVersion); + version = Version.getLatest(); } return version; } diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java index 5f0bd0d..5c95a27 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Version.java @@ -65,6 +65,10 @@ return val.toString(); } + public static Version getLatest() { + return ALL.get(ALL.size() -1); + } + private static void appendVersionComponent(StringBuilder val, int versionNumber) { if (versionNumber > -1) { if (val.length() != 0) { -- To view, visit http://gerrit.ovirt.org/25634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I53373e9ce2563d91a96353f068cd19069508399d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Eli Mesika <emes...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
