Moti Asayag has posted comments on this change. Change subject: core : Fixing a release lock for case of MultipleActionRunner ......................................................................
Patch Set 1: wouldn't be better putting the release in case of a CAD failure on CommandBase.CanDoActionOnly rather than on CommandBase.InternalCanDoAction ? In this case, releasing the lock will be performed only once. However, if you put it inside the CommandBase.InternalCanDoAction, it will be performed twice (on on InternalCanDoAction finally block and once in ExecuteAction) for failure of commands which weren't invoked by the multiple action runner and failed on their CDA. -- To view, visit http://gerrit.ovirt.org/4671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I540495f97994f8f53cd072bb43cdeedfcdc46907 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
