Roy Golan has posted comments on this change. Change subject: core: Updating roles.is_inheritable properly ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddRoleWithActionGroupsCommand.java Line 102: role.setInheritable(false); not a show stopper but I think setting the property on the role only is better in 1. gives that admin the ability to configure a role (Action group is not a building block the admin can interact with) 2. easier impl - no need to consider what the underlying roles are about naming - you suggest allowView... something. Everything is better that inheritance -- To view, visit http://gerrit.ovirt.org/4607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69eff9d99d3c54fe8b7688dca5cd108f6f306e07 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
