Omer Frenkel has posted comments on this change. Change subject: core: VURTI - fix handle expection in GetVmStats ......................................................................
Patch Set 3: Code-Review+1 (4 comments) http://gerrit.ovirt.org/#/c/25548/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java: Line 52 Line 53 Line 54 Line 55 Line 56 this probably can be excluded from the patch http://gerrit.ovirt.org/#/c/25548/3/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 96: private final AtomicInteger mFailedToRunVmAttempts; Line 97: private final AtomicInteger mUnrespondedAttempts; Line 98: private final AtomicBoolean sshSoftFencingExecuted; Line 99: Line 100: private int VDS_DURING_FAILURE_TIMEOUT_IN_MINUTES = Config you left a double space here Line 101: .<Integer> getValue(ConfigValues.TimeToReduceFailedRunOnVdsInMinutes); Line 102: private String duringFailureJobId; Line 103: private boolean privateInitialized; Line 104: http://gerrit.ovirt.org/#/c/25548/3/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfoTest.java: Line 273: } Line 274: Line 275: /** Line 276: * Test that when we fail in getting a response for GetVmStats we still insert the VM to the runningVms structure,<br> Line 277: * but with status UNKNOWN note about status should be removed Line 278: */ Line 279: @Test Line 280: public void verifyListOfRunningVmsIsSameWithFailureOnGetVmStats() { Line 281: prepareForRefreshVmStatsCall(); Line 282: mockGetVmStatsCommand(false); Line 283: // start refreshing vm data... VURTI now fetches Vms list from ResourceManager and loop through it Line 284: updater.fetchRunningVms(); Line 285: List<VM> runningAndUnchanged = updater.checkVmsStatusChanged(); Line 286: Assert.assertTrue("expecting the VM to be missing from the running VMs map", !updater.getRunningVms().containsKey(VM_1)); why missing? i thought we leave it in this list Line 287: Assert.assertFalse(runningAndUnchanged.contains(VM_1)); Line 288: } Line 289: Line 290: private void prepareForRefreshVmStatsCall() { -- To view, visit http://gerrit.ovirt.org/25548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I415804d9fa1f1288423241b8547f4cab5540914a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
