Arik Hadas has posted comments on this change. Change subject: backend: Enable configuration of VM serial number ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/25099/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java: Line 307: vmBase I also think that the indentation is better that way but the engine-code-formatter will revert this change the next time people will apply the formatter.. so it's better to just keep the indentation as it was before http://gerrit.ovirt.org/#/c/25099/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java: Line 236: List<Disk> diskImages = new ArrayList<Disk>(vm.getDiskMap() Line 237: .values()); Line 238: Collections.sort(diskImages, new DiskImageByDiskAliasComparator()); Line 239: Collections.sort(diskImages, Line 240: Collections.reverseOrder(new DiskImageByBootAndSnapshotComparator())); same as the previous comment on indentation Line 241: return diskImages; Line 242: } Line 243: Line 244: protected void logUnsupportedInterfaceType() { http://gerrit.ovirt.org/#/c/25099/4/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 632: --URL or custom message to be presented upon login when the password of a user has expired. Line 633: select fn_db_add_config_value('ChangePasswordMsg','','general'); Line 634: Line 635: select fn_db_add_config_value('DefaultSerialNumberPolicy','HOST_ID','general'); Line 636: select fn_db_add_config_value('DefaultCustomSerialNumber','Dummy serial number.','general'); if the default policy is host-id then the default number should be null right? why do we need to have default custom serial number anyway? if the user choose custom policy - let's enforce him to specify the custom number Line 637: Line 638: ------------------------------------------------------------------------------------ Line 639: -- Update with override section Line 640: ------------------------------------------------------------------------------------ -- To view, visit http://gerrit.ovirt.org/25099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife7eb050ccf59603b905d16fd72e77521d4579df Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
