Alon Bar-Lev has posted comments on this change.

Change subject: core: preserve custom db users permissions on...
......................................................................


Patch Set 5:

> BTW: using this approach will not apply custom permission if anything fails 
> during execution.

only valid way I can think of is storing these statement within a table, so 
that in future run we skip our detection and apply statements from the table.

we must be very careful in this solution so that people will not put values 
that can be abused if script runs under postgres user.

-- 
To view, visit http://gerrit.ovirt.org/25552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4ac85dc943fcb6a8f656a8ebeb172023e71c1ec
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to