Sandro Bonazzola has posted comments on this change.

Change subject: sos: added ovirt_engine_reports sos plugin
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25519/1/src/sos/plugins/ovirt_engine_reports.py
File src/sos/plugins/ovirt_engine_reports.py:

Line 24: class ovirt_engine_reports(PluginBase):
Line 25:     """oVirt Engine Reports related information"""
Line 26: 
Line 27:     def setup(self):
Line 28:         self.addCopySpec('/var/log/ovirt-engine-reports')
> why? you need to collect these logs.
I mean further updates to this plugins. I'm going to merge this as is.
Line 29: 
Line 30: 


-- 
To view, visit http://gerrit.ovirt.org/25519
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id76ce5a1cd835fa160057a7d9d71aae82f1669f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Tomáš Došek <tdo...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to