Tomas Jelinek has posted comments on this change. Change subject: UI: Cloud-Init gateway is not mandatory ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25301/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IpAddressValidation.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/IpAddressValidation.java: Line 14: Line 15: public IpAddressValidation(boolean allowEmpty) { Line 16: String empty = (allowEmpty) ? EMPTY_REGEX : ""; //$NON-NLS-1$ Line 17: setExpression("^" + IP_ADDRESS_REGEX + empty + "$"); //$NON-NLS-1$ $NON-NLS-2$ Line 18: setMessage(ConstantsManager.getInstance().getConstants().thisFieldMustContainIPaddressInFormatMsg()); > I don't think so... yes, but if the user will enter something like: "I'm not an expert in networking, but I guess this is an invalid IP" than the validation message will say: "This field must contain an IP address in format xxx.xxx.xxx.xxx" and that is not true since the IP can also be empty (and the user is supposed to be told that he can just leave this field blank otherwise it will seem that he has to fill a valid IP in). So the message should be something like: "This field must either be empty or contain an IP address in format xxx.xxx.xxx.xxx" Line 19: } -- To view, visit http://gerrit.ovirt.org/25301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9b8fb3fd84158ee7c80662e85125b26d22148daa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
