Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix Audit log and can do action msgs handling in ldap broker. ......................................................................
Patch Set 4: (2 comments) Why not setting it in "configuration" (ExtensionsProperties.CONFIGURATION) same way we handle profile name? http://gerrit.ovirt.org/#/c/25529/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/aaa/provisional/ProvisionalAuthenticator.java: Line 63: Line 64: } Line 65: } Line 66: } Line 67: passwordChangeMsgUrl = passwordChangeMsgPerDomain.get(getProfileName()); > why don't you put it in context? Done Line 68: Line 69: } Line 70: Line 71: http://gerrit.ovirt.org/#/c/25529/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 38: private static final Map<AAAExtensionError, VdcBllMessages> vdcBllMessagesMap = new HashMap<>(); Line 39: Line 40: Line 41: //Called from InitOnStartup service Line 42: public static void init() { > this can be in static context, no? Done Line 43: auditLogMap.put(AAAExtensionError.CREDENTIALS_EXPIRED, AuditLogType.USER_ACCOUNT_PASSWORD_EXPIRED); Line 44: auditLogMap.put(AAAExtensionError.GENERAL_ERROR, AuditLogType.USER_VDC_LOGIN_FAILED); Line 45: auditLogMap.put(AAAExtensionError.INCORRET_CREDENTIALS, AuditLogType.AUTH_FAILED_INVALID_CREDENTIALS); Line 46: auditLogMap.put(AAAExtensionError.LOCKED_OR_DISABLED_ACCOUNT, AuditLogType.USER_ACCOUNT_DISABLED_OR_LOCKED); -- To view, visit http://gerrit.ovirt.org/25529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b0b024d27a92f620bb60e4689264bc6b3c3eda1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
