Alon Bar-Lev has posted comments on this change.

Change subject: packaging: setup: display only top level setup packages
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25503/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py
File 
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py:

Line 201
Line 202
Line 203
Line 204
Line 205
> why not just this instead:
I was about to write good idea and actually implement that... when remembered 
that this can not be the case when we have obsolete, provides and such.

so safest approach is to update and see if transaction is not empty.


-- 
To view, visit http://gerrit.ovirt.org/25503
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a1f27090aa362882047007416aacff1cb5dbc4c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to