Vojtech Szocs has posted comments on this change. Change subject: webadmin: tabbar position off on login ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25442/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/HeaderPresenterWidget.java: Line 114 Line 115 Line 116 Line 117 Line 118 You might also want to remove MAIN_TABBAR_INITIAL_OFFSET constant. It seems that default west stack panel (MainSectionView.westStackPanel) size is 235px to which MAIN_TABBAR_INITIAL_OFFSET correlated. Without this code, if someone changes west stack panel size, how will we correlate tab bar offset? -- To view, visit http://gerrit.ovirt.org/25442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63b6b48e15fbb7cf4a5a76865609c1fc5f1a14a9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
