Alona Kaplan has uploaded a new change for review. Change subject: webadmin: Saving a dialog pressing ENTER inconsistent with clicking OK ......................................................................
webadmin: Saving a dialog pressing ENTER inconsistent with clicking OK When clicking on OK button (or any other footer button) the view is flushed before the command is executed. Pressing "ESC" or "ENTER" should be consistent with clicking the footer button "CANCEL" or "OK". Change-Id: Iaf0e2d0de5f905af13d99eec5f7403bb72b8f02c Bug-Url: https://bugzilla.redhat.com/1059578 Signed-off-by: Alona Kaplan <alkap...@redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/25457/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java index 5d7bf80..a15f394 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java @@ -203,12 +203,14 @@ @Override protected void handleEnterKey() { + getView().flush(); beforeCommandExecuted(model.getDefaultCommand()); modelCommandInvoker.invokeDefaultCommand(); } @Override protected void handleEscapeKey() { + getView().flush(); beforeCommandExecuted(model.getCancelCommand()); modelCommandInvoker.invokeCancelCommand(); } -- To view, visit http://gerrit.ovirt.org/25457 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf0e2d0de5f905af13d99eec5f7403bb72b8f02c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4.0 Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
