Moti Asayag has posted comments on this change. Change subject: engine: Improve cannot label bond message ......................................................................
Patch Set 6: (2 comments) http://gerrit.ovirt.org/#/c/25342/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/LabelNicCommand.java: Line 65: return failCanDoAction(VdcBllMessages.INTERFACE_ALREADY_LABELED); Line 66: } Line 67: Line 68: if (!ValidationUtils.validateInputs(getValidationGroups(), getNic()).isEmpty()) { Line 69: return failCanDoAction(VdcBllMessages.IMPROPER_BOND_IS_LABELED); > Didn't you mean to change the key on line 84? Done Line 70: } Line 71: Line 72: if (Boolean.TRUE.equals(getNic().getBonded())) { Line 73: int slavesCount = 0; http://gerrit.ovirt.org/#/c/25342/6/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 719: VDS_GROUP_CANNOT_DISABLE_GLUSTER_WHEN_CLUSTER_CONTAINS_VOLUMES=Cannot disable gluster service on the cluster as it contains volumes. Line 720: NETWORK_ATTACH_ILLEGAL_GATEWAY=The default gateway should be set only on the Management Network Line 721: SLAVE_INTERFACE_IS_MISCONFIGURED=A slave interface is not properly configured. Please verify slaves do not contain any of the following properties: network name, boot protocol, IP address, netmask, gateway or vlan-ID notation (as part of interface's name or explicitly). Line 722: IMPROPER_INTERFACE_IS_LABELED=Cannot ${action} ${type}. An improper network interface is labeled. Please verify labels are provided only to interfaces or to bonds (not to slaves nor vlans). Line 723: IMPROPER_BOND_IS_LABELED=Cannot ${action} ${type}. An improper bond is labeled. Please verify DAlabels are provided only to bonds with at least two slaves. > What is DAlabels? Done Line 724: INTERFACE_ALREADY_LABELED=Cannot ${action} ${type}. The network interface is already labeled with the specified label. Line 725: INTERFACE_NOT_LABELED=Cannot ${action} ${type}. The network interface is not labeled with the specified label. Line 726: MISSING_DIRECTORY_ELEMENT_ID=User/group ID cannot be empty. Line 727: NETWORK_ILEGAL_NETWORK_NAME=Network name must be 1-15 long and can contain only 'A-Z', 'a-z', '0-9', '_' characters -- To view, visit http://gerrit.ovirt.org/25342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I250c56d0f6a70dbe8da89a3aa5b28592f9a0a995 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
