Oved Ourfali has posted comments on this change. Change subject: core: Fix group population ......................................................................
Patch Set 1: Code-Review+1 (1 comment) minor comment. http://gerrit.ovirt.org/#/c/25407/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java: Line 162: groupsDict.put(group.getname(), group); Line 163: proceedGroupsSearchResult(groupsResult.getId(), groupsList, groupsDict, generator); Line 164: } Line 165: Line 166: private void proceedGroupsSearchResult(ExternalId groupId, List<String> groupDNList, I don't see that groupId is used here.. Line 167: Map<String, LdapGroup> groupsDict, GroupsDNQueryGenerator generator) { Line 168: if (groupDNList == null) { Line 169: return; Line 170: } -- To view, visit http://gerrit.ovirt.org/25407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I599fca005b27f6873cda3e5a46081de3357089b2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
