Federico Simoncelli has posted comments on this change. Change subject: core: glance import as template should fail on old DCs ......................................................................
Patch Set 2: Code-Review+1 (2 comments) I am giving a +1 because I want to see this merged and I won't be available tomorrow, but please address the comments if they're indeed relevant. Thanks! http://gerrit.ovirt.org/#/c/25286/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportRepoImageCommand.java: Line 203: } Line 204: Line 205: setStoragePoolId(getParameters().getStoragePoolId()); Line 206: if (!FeatureSupported.importGlanceImageAsTemplate(getStoragePool().getcompatibility_version())) { Line 207: return failCanDoAction(VdcBllMessages.ACTION_NOT_SUPPORTED_FOR_CLUSTER_POOL_LEVEL); Are you sure that "CLUSTER_POOL_LEVEL" is the correct error? Shouldn't it be something like "DATACENTER_LEVEL" (sorry, I have no way to check this myself now). Line 208: } Line 209: } Line 210: Line 211: DiskImage diskImage = null; http://gerrit.ovirt.org/#/c/25286/2/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 206: select fn_db_add_config_value('ImportGlanceImageAsTemplate','false','3.0'); Line 207: select fn_db_add_config_value('ImportGlanceImageAsTemplate','false','3.1'); Line 208: select fn_db_add_config_value('ImportGlanceImageAsTemplate','false','3.2'); Line 209: select fn_db_add_config_value('ImportGlanceImageAsTemplate','false','3.3'); Line 210: select fn_db_add_config_value('ImportGlanceImageAsTemplate','true','3.4'); you don't need this entry, by default it's already true Line 211: select fn_db_add_config_value('HotPlugDiskSnapshotSupported','false','3.0'); Line 212: select fn_db_add_config_value('HotPlugDiskSnapshotSupported','false','3.1'); Line 213: select fn_db_add_config_value('HotPlugDiskSnapshotSupported','false','3.2'); Line 214: select fn_db_add_config_value('GetFileStats','false','3.0'); -- To view, visit http://gerrit.ovirt.org/25286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b975d2f8d540af6f0a3c8e4de9296173950f9ce Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
