Doron Fediuck has posted comments on this change. Change subject: engine: allow values higher than 9 minutes for CpuOverCommitDuration ......................................................................
Patch Set 3: (1 comment) please see inline http://gerrit.ovirt.org/#/c/25200/3/packaging/dbscripts/upgrade/03_05_0070_allow_values_higher_9_for_cpuovercommit.sql File packaging/dbscripts/upgrade/03_05_0070_allow_values_higher_9_for_cpuovercommit.sql: Line 1: -- 736999d0-1023-46a4-9a75-1316ed50e151 - PowerSaving Line 2: UPDATE policy_units set custom_properties_regex = '{ Line 3: "CpuOverCommitDurationMinutes" : "^([1-9][0-9]*)$", Line 4: "HighUtilization" : "^([5-9][0-9])$", Line 5: "LowUtilization" : "^([1-4][0-9])$" > LowUtilization regex does just recognize values from 10-49 but excludes Maybe use something like this- 1[0-2]|[1-9] Should allow 2 digits or one (please verify!) Line 6: }' Line 7: WHERE id = '736999d0-1023-46a4-9a75-1316ed50e151'; Line 8: Line 9: -- 7db4ab05-81ab-42e8-868a-aee2df483ed2 - EvenDistribution -- To view, visit http://gerrit.ovirt.org/25200 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b8b4f7b4f8ef76dc9774dc1620e6bb76aaf2f65 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Kobi Ianko <k...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sven Kieske <svenkieskemittw...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
