Lior Vernia has uploaded a new change for review. Change subject: webadmin: Enable vertical scrolling in bond dialog ......................................................................
webadmin: Enable vertical scrolling in bond dialog This is required since the addition of labels, of which many could exist. Change-Id: I54ae2350eeb1dc23b222915f99df8f15882c67ae Bug-Url: https://bugzilla.redhat.com/1063852 Signed-off-by: Lior Vernia <lver...@redhat.com> (cherry picked from commit 49d7f0ea5d61f3981a4d8559f360999f381efd52) --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java 4 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/25423/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml index 2092ebb..b29e7c3 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostBondPopupView.ui.xml @@ -17,7 +17,7 @@ <d:SimpleDialogPanel width="400px" height="600px"> <d:content> <g:DockLayoutPanel ui:field="layoutPanel"> - <g:north size="330"> + <g:north size="329"> <g:VerticalPanel ui:field="mainPanel"> <e:ListModelSuggestBoxEditor ui:field="bondSuggestEditor" /> <e:ListModelListBoxEditor ui:field="bondEditor" /> diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java index 3185d26..8203be4 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelEditor.java @@ -28,7 +28,8 @@ public NicLabelEditor() { suggestBoxEditor = new ListModelSuggestBoxEditor(); initWidget(suggestBoxEditor); - getElement().getStyle().setMarginTop(10, Unit.PX); + getElement().getStyle().setMarginTop(5, Unit.PX); + getElement().getStyle().setMarginBottom(5, Unit.PX); driver.initialize(this); } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml index 56fd4a7..a6da61c 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/NicLabelWidget.ui.xml @@ -16,7 +16,7 @@ height: 10px; padding-left: 2px; padding-top: 2px; - margin-top: 16px; + margin-top: 11px; margin-left: 20px; } @@ -29,7 +29,7 @@ <g:FlowPanel addStyleNames="{style.mainPanel}" > <g:Label text="{constants.labelsHostPopup}" addStyleNames="{style.labelStyle}" /> - <g:ScrollPanel> + <g:ScrollPanel height="249px"> <g:FlowPanel ui:field="contentPanel" /> </g:ScrollPanel> </g:FlowPanel> diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java index 0292756..cd6edf0 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksBondPopupView.java @@ -29,7 +29,6 @@ message.setVisible(false); // resize layoutPanel.remove(infoPanel); - layoutPanel.setWidgetSize(mainPanel, 300); asPopupPanel().setPixelSize(400, 400); } -- To view, visit http://gerrit.ovirt.org/25423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I54ae2350eeb1dc23b222915f99df8f15882c67ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lver...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
