Alona Kaplan has posted comments on this change. Change subject: webadmin: Added host interface label character validation ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25014/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NicLabelModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/NicLabelModel.java: Line 68: .getMessages() Line 69: .labelInUse(label, usingIface)); Line 70: labelModel.setIsValid(false); Line 71: } Line 72: res &= labelModel.getIsValid(); Why do you use bitwise AND? Line 73: } Line 74: return res; Line 75: } Line 76: -- To view, visit http://gerrit.ovirt.org/25014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25bef382cb658e6e78bf5e2e0cfd1a273280d953 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
