Lior Vernia has posted comments on this change. Change subject: webadmin: label group in setup networks shouldn't have tooltip ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/25011/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java: Line 57: showRelativeTo(panel); Line 58: } else if (item instanceof NetworkInterfaceModel) { Line 59: showNic((NetworkInterfaceModel) item); Line 60: showRelativeTo(panel); Line 61: } > Maybe it would be better to just add another "else if" for NetworkLabelMode Just to clarify, and I meant leave the showRelativeTo() call at the end rather than repeat it. In the clause for NetworkLabelModel we can just call return. Line 62: } Line 63: Line 64: private void addRow(String label, String value) { Line 65: int rowCount = contents.insertRow(contents.getRowCount()); -- To view, visit http://gerrit.ovirt.org/25011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c46d850f5452b7318e52c6ea5494a3ab2c6a3da Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
