Tomas Jelinek has posted comments on this change. Change subject: frontend: Control virtio rng device ......................................................................
Patch Set 12: (4 comments) you miss the corresponding setting of the device to params in the pool list model I would say.. http://gerrit.ovirt.org/#/c/18497/12/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 1523: Line 1524: /** Line 1525: * integer, null or nfexception Line 1526: * @param s Line 1527: * @return please remove the empty parts of the comment (e.g. @param s, @return) Line 1528: */ Line 1529: private static Integer parseIntOrNull(String s) { Line 1530: if (s == null) { Line 1531: return null; Line 1682: kernel_pathEditor.setTabIndex(nextTabIndex++); Line 1683: initrd_pathEditor.setTabIndex(nextTabIndex++); Line 1684: kernel_parametersEditor.setTabIndex(nextTabIndex++); Line 1685: Line 1686: // ==Rng Tab== you miss something like: nextTabIndex = rngDeviceTab.setTabIndexes(nextTabIndex); Line 1687: isRngEnabledEditor.setTabIndex(nextTabIndex++); Line 1688: rngPeriodEditor.setTabIndex(nextTabIndex++); Line 1689: rngBytesEditor.setTabIndex(nextTabIndex++); Line 1690: rngSourceRandom.setTabIndex(nextTabIndex++); http://gerrit.ovirt.org/#/c/18497/12/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 1369: setSsoMethodGuestAgent(new NotChangableForVmInPoolEntityModel<Boolean>()); Line 1370: setConsoleDeviceEnabled(new NotChangableForVmInPoolEntityModel<Boolean>()); Line 1371: setCopyPermissions(new NotChangableForVmInPoolEntityModel<Boolean>()); Line 1372: Line 1373: //rng please use the generic versions like this: new NotChangableForVmInPoolEntityModel<Boolean>(); instead of: new NotChangableForVmInPoolEntityModel(); Line 1374: setIsRngEnabled(new NotChangableForVmInPoolEntityModel()); Line 1375: getIsRngEnabled().getEntityChangedEvent().addListener(this); Line 1376: setRngBytes(new NotChangableForVmInPoolEntityModel()); Line 1377: setRngPeriod(new NotChangableForVmInPoolEntityModel()); Line 1377: setRngPeriod(new NotChangableForVmInPoolEntityModel()); Line 1378: setRngSourceRandom(new NotChangableForVmInPoolEntityModel()); Line 1379: setRngSourceHwrng(new NotChangableForVmInPoolEntityModel()); Line 1380: Line 1381: setCopyPermissions(new NotChangableForVmInPoolEntityModel()); please remove this line Line 1382: Line 1383: // by default not available - only for new VM Line 1384: getCopyPermissions().setIsAvailable(false); Line 1385: getCopyPermissions().setEntity(false); -- To view, visit http://gerrit.ovirt.org/18497 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffbc48062f25d90795bc360362f42cd1042fb888 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
