Mike Kolesnik has posted comments on this change. Change subject: engine: Display network must have boot protocol ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/25016/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 497: NETWORK_MTU_OVERRIDE_NOT_SUPPORTED(ErrorType.CONFLICT), Line 498: EXTERNAL_NETWORK_CANNOT_BE_PROVISIONED(ErrorType.NOT_SUPPORTED), Line 499: NETWORK_LABEL_FORMAT_INVALID(ErrorType.BAD_PARAMETERS), Line 500: ACTION_TYPE_FAILED_CANNOT_REMOVE_LABELED_NETWORK_FROM_NIC(ErrorType.CONFLICT), Line 501: ACTION_TYPE_FAILED_CANNOT_CONFIGURE_DISPLAY_NETWORK_WITHOUT_BOOT_PROTOCOL(ErrorType.BAD_PARAMETERS), This key name is confusing since you're using it when scheduling a VM not configuring the network, can you please change it? Line 502: IMPROPER_INTERFACE_IS_LABELED(ErrorType.BAD_PARAMETERS), Line 503: INTERFACE_ALREADY_LABELED(ErrorType.CONFLICT), Line 504: INTERFACE_NOT_LABELED(ErrorType.CONFLICT), Line 505: LABELED_NETWORK_ATTACHED_TO_WRONG_INTERFACE(ErrorType.CONFLICT), -- To view, visit http://gerrit.ovirt.org/25016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14e5a0edae8524a7334609e58934880a722ca87f Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
