Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: database: suppress password based on env key ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/25347/3/packaging/setup/plugins/ovirt-engine-rename/core/pki.py File packaging/setup/plugins/ovirt-engine-rename/core/pki.py: Line 63: self.environment[ Line 64: otopicons.CoreEnv.LOG_FILTER_KEYS Line 65: ].append( Line 66: osetupcons.PKIEnv.STORE_PASS Line 67: ) > this is rename and the other is setup we need this in both. > this is rename and the other is setup we need this in both. Didn't notice :-( Can be done in common? > about adding one of them... I consider this and decided to go safe for now, > removing the chance of answer file leak. can you please remove the suppress > and check it out without? How is that related to the answer file? We do save there secrets. I thought SUPPRESS_ENVIRONMENT_KEYS is for dump_environment (after each event) and LOG_FILTER_KEYS is for logging, no? And I asked whether we can use just one (by changing otopi to use just one, or for compatibility, check both always, for now)? Line 68: Line 69: @plugin.event( Line 70: stage=plugin.Stages.STAGE_INIT, Line 71: ) -- To view, visit http://gerrit.ovirt.org/25347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4d1ad9b0acda23a59f55d1653a542c9ea038754 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
