Yair Zaslavsky has posted comments on this change. Change subject: core: fix coverity issue ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25189/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KrbConfCreator.java: Line 167: } else { Line 168: // Fill in [domain_realm] section from the provided file at engine-manage-domains.conf Line 169: // This can be useful in case the realm is not an upper case of the domain Line 170: try (BufferedReader reader = Line 171: new BufferedReader(new InputStreamReader(new FileInputStream(domainRealmMappingFile), "UTF-8"))) { > This would probably works in most case (since most of users using UTF-8 tod good to know, thanks for the tip. Line 172: while (true) { Line 173: String readLine = reader.readLine(); Line 174: if (readLine == null) { Line 175: break; -- To view, visit http://gerrit.ovirt.org/25189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2557a58aa73f4be8b03f1357ecaa9668b725145 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
