Alon Bar-Lev has uploaded a new change for review.

Change subject: packaging: setup: database: suppress password based on env key
......................................................................

packaging: setup: database: suppress password based on env key

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1072476
Change-Id: Ia4d1ad9b0acda23a59f55d1653a542c9ea038754
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py
2 files changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-dwh refs/changes/62/25362/1

diff --git 
a/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py 
b/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py
index 31236d5..ce8a31d 100644
--- 
a/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py
+++ 
b/packaging/setup/plugins/ovirt-engine-common/ovirt-engine-dwh/db/connection.py
@@ -52,6 +52,11 @@
         ].append(
             odwhcons.DBEnv.PASSWORD
         )
+        self.environment[
+            otopicons.CoreEnv.LOG_FILTER_KEYS
+        ].append(
+            odwhcons.DBEnv.PASSWORD
+        )
 
     @plugin.event(
         stage=plugin.Stages.STAGE_INIT,
@@ -131,10 +136,6 @@
                     )
                 ):
                     dbenv[e] = config.getboolean(k)
-
-                self.environment[otopicons.CoreEnv.LOG_FILTER].append(
-                    dbenv[odwhcons.DBEnv.PASSWORD]
-                )
 
                 dbovirtutils = database.OvirtUtils(
                     plugin=self,
diff --git 
a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py 
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py
index 677bab6..193ebe0 100644
--- 
a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py
+++ 
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/db/connection.py
@@ -243,8 +243,6 @@
                     hidden=True,
                 )
 
-                self.environment[otopicons.CoreEnv.LOG_FILTER].append(password)
-
             dbenv = {
                 odwhcons.DBEnv.HOST: host,
                 odwhcons.DBEnv.PORT: port,


-- 
To view, visit http://gerrit.ovirt.org/25362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4d1ad9b0acda23a59f55d1653a542c9ea038754
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to