Omer Frenkel has posted comments on this change. Change subject: core: Remove check for force flag when validating remove VM in preview. ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/25176/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java: Line 200: if (!validate(snapshotsValidator.vmNotDuringSnapshot(getVmId()))) { Line 201: return false; Line 202: } Line 203: Line 204: if (!validate(snapshotsValidator.vmNotInPreview(getVmId()))) { i think it would make more sense not to check this if we user request force remove Line 205: return false; Line 206: } Line 207: Line 208: if (!validate(new StoragePoolValidator(getStoragePool()).isUp())) { -- To view, visit http://gerrit.ovirt.org/25176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c43440ef999bdbb573f6038a2f6b5d01411f2ea Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
