Lior Vernia has posted comments on this change. Change subject: webadmin: Adding Quota column to the Disk tab ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/25068/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/disks/DisksViewColumns.java: Line 56: Line 57: String value = null; Line 58: if (object.getDiskStorageType() == DiskStorageType.IMAGE) { Line 59: DiskImage diskImage = (DiskImage) object; Line 60: value = diskImage.getQuotaName(); > it's possible with template I think you can use StringHelper.join() to easily display a serialized string representing the collection. Line 61: } Line 62: return value; Line 63: } Line 64: }; http://gerrit.ovirt.org/#/c/25068/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java: Line 180: DisksViewColumns.lunProductIdColumn, constants.productIdSanStorage(), luns, Line 181: "100px"); //$NON-NLS-1$ Line 182: Line 183: getTable().ensureColumnPresent( Line 184: DisksViewColumns.qoutaColumn, constants.qoutaDisk(), (all || images || luns) && isQuotaVisible, "120px"); //$NON-NLS-1$ > because it's a table in case we select "All", we will have a cell on a LUN I think I saw some, but none of it had to do with networking so I don't remember them. I'm perfectly okay with an empty value when it's not relevant, but if you are as well, then I'm not sure it was necessary to bend over backwards to avoid showing the column when the DC selected in the tree didn't support quotas. Line 185: Line 186: getTable().ensureColumnPresent( Line 187: DisksViewColumns.descriptionColumn, constants.descriptionDisk(), all || images || luns, Line 188: "90px"); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/25068 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2332da722396a16aca9545b9ef0532ebc84d8d5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kobi Ianko <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
