Maor Lipchuk has posted comments on this change. Change subject: webadmin: expose the V3 domain format in dc 3.1 ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (2 inline comments) logic looks good, minor comments .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageDomainCommand.java Line 154: final StorageType storageType = getStorageDomain().getstorage_type(); storageType can be initialized inside the if command since it is only used for storage type V2 .................................................... Commit Message Line 7: webadmin: expose the V3 domain format in dc 3.1 Please add core in the commit message, or separate the patch to backend and frontend. -- To view, visit http://gerrit.ovirt.org/4476 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibafcb53007eb6e531f024cd054ff2673a7d431e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
