Eli Mesika has posted comments on this change. Change subject: core: force engine-config to run as root ......................................................................
Patch Set 1: (3 comments) Alon , were did you saw that this script is using /var/log ??? http://gerrit.ovirt.org/#/c/25312/1/packaging/bin/engine-config.sh File packaging/bin/engine-config.sh: Line 69: ;; Line 70: esac Line 71: done Line 72: } Line 73: > unrelated will remove Line 74: # do this in function so we do not lose $@ Line 75: parseArgs "$@" Line 76: Line 77: [ -s "${CONF_FILE}" ] || die "Configuration file '${CONF_FILE}' is either empty or does not exist" Line 77: [ -s "${CONF_FILE}" ] || die "Configuration file '${CONF_FILE}' is either empty or does not exist" Line 78: . "${CONF_FILE}" Line 79: Line 80: # Make sure only root can run our script Line 81: if [[ $EUID -ne 0 ]]; then > please do not use bashism replace with that ??? if [ "$EUID" = "0" ]; then Line 82: echo "This script must be run as root" 1>&2 Line 83: exit 1 Line 84: fi Line 85: Line 79: Line 80: # Make sure only root can run our script Line 81: if [[ $EUID -ne 0 ]]; then Line 82: echo "This script must be run as root" 1>&2 Line 83: exit 1 > please use die OK Line 84: fi Line 85: Line 86: # Line 87: # Add this option to the java command line to enable remote debugging in -- To view, visit http://gerrit.ovirt.org/25312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42190236f29abe3c8af4fd4c83cca9abe54613e1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
