Alon Bar-Lev has uploaded a new change for review. Change subject: packaging: setup: database: move connect to database library ......................................................................
packaging: setup: database: move connect to database library this will enable use of single tweaks for different driver versions. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1067058 Change-Id: I7e6abd911d10013fcbb904254762d90a125078e8 Signed-off-by: Alon Bar-Lev <alo...@redhat.com> --- M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py 1 file changed, 4 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-reports refs/changes/33/25333/1 diff --git a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py index 7f73d0d..2e61e3e 100644 --- a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py +++ b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/db/connection.py @@ -301,22 +301,16 @@ ), ) def _connection(self): - # must be here as we do not have database at validation - self.environment[ - oreportscons.DBEnv.CONNECTION - ] = psycopg2.connect( - host=self.environment[oreportscons.DBEnv.HOST], - port=self.environment[oreportscons.DBEnv.PORT], - user=self.environment[oreportscons.DBEnv.USER], - password=self.environment[oreportscons.DBEnv.PASSWORD], - database=self.environment[oreportscons.DBEnv.DATABASE], - ) self.environment[ oreportscons.DBEnv.STATEMENT ] = database.Statement( environment=self.environment, dbenvkeys=oreportscons.Const.REPORTS_DB_ENV_KEYS, ) + # must be here as we do not have database at validation + self.environment[ + oreportscons.DBEnv.CONNECTION + ] = self.environment[oreportscons.DBEnv.STATEMENT].connect() # vim: expandtab tabstop=4 shiftwidth=4 -- To view, visit http://gerrit.ovirt.org/25333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e6abd911d10013fcbb904254762d90a125078e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
